fix: add client_id and client_secret to revokeOAuth2Token
#3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
previously approved these changes
Nov 28, 2022
jonas-jonas
force-pushed
the
fix/revokeOAuth2TokenClientIdClientSecret
branch
from
367154d
to
3b29393
Compare
|
@aeneasr I don't actually think the values are required. Removed the |
Codecov Report
@@ Coverage Diff @@
## master #3373 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 123 123
Lines 8964 8964
=======================================
Hits 6898 6898
Misses 1639 1639
Partials 427 427
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Supersedes #3261
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments